Ast address-of #66671
Merged
Ast address-of #66671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
matthewjasper
force-pushed
the
ast-address-of
branch
from
fa22779 to
dd9bc78
Compare
GuillaumeGomez
requested changes
Nov 23, 2019
Centril
reviewed
Nov 23, 2019
Centril
added
S-waiting-on-author
RalfJung
reviewed
Nov 24, 2019
matthewjasper
force-pushed
the
ast-address-of
branch
from
dd9bc78 to
f4efc5d
Compare
Centril
added
S-waiting-on-review
|
@bors r=Centril |
|
📌 Commit f4efc5d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
|
📣 Toolstate changed by #66671! Tested on commit c9bacb7. 💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 25, 2019
Tested on commit rust-lang/rust@c9bacb7. Direct link to PR: <rust-lang/rust#66671> 💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 25, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 27, 2019
Rustup Rustups: - rust-lang/rust#66671 (Ast address-of) - rust-lang/rust#64856 (Scope format! temporaries) changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 27, 2019
Rustup to rustc 1.41.0-nightly (e87a205 2019-11-27) Rustups: - rust-lang/rust#66671 (Ast address-of) - rust-lang/rust#64856 (Scope format! temporaries) - http://github.com/rust-lang/rust/pull/66719 changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 27, 2019
Rustup to rustc 1.41.0-nightly (e87a205 2019-11-27) Rustups: - rust-lang/rust#66671 (Ast address-of) - rust-lang/rust#64856 (Scope format! temporaries) - http://github.com/rust-lang/rust/pull/66719 changelog: none
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the parts of #64588 that don't affect MIR. If an address-of expression makes it to MIR lowering we error and lower to the best currently expressible approximation to limit further errors.
r? @Centril